-
-
Notifications
You must be signed in to change notification settings - Fork 861
deps: remove unnecessary dependencies #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
IIRC, the file binary is used by Symfony (HttpFoundation?) to guess the mime type of uploaded files. I'm not sure about the other tools. We used to use |
@dunglas you are right. Found usage of the Thanks for pointing this out! |
If |
@danut007ro I agree. But I'm not sure if git can be a mandatory dependency for some Composer scenarios. Maybe there is some information why git might be needed for Composer and whether this dependency is important? |
@zpi12lmm yes, and this PR removes them. These lines do not carry any useful payload within this template. The container always starts as root by default (and some entrypoint lines will only work as root), so there is no need to grant file permissions to www-data and the current user (the same root). |
@7-zete-7 Can you resolve conflicts? pls |
@maxhelias Resolved conflicts |
Thanks! |
I suggest removing the following dependencies:
acl
gettext
These dependencies are not used or have no useful functionality.
See #819