Skip to content

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Sep 9, 2025

Description

This pull request makes minor updates to the workspace versioning and improves filesystem compatibility in the project.

Version updates:

  • Bumped the workspace package version in Cargo.toml from 1.0.16 to 1.0.17, and updated all internal dependencies to use the new version for consistency. [1] [2]

Filesystem compatibility:

  • Updated the fallocate function in dragonfly-client-util/src/fs/mod.rs to gracefully handle unsupported fallocate operations by logging a warning and skipping preallocation, improving compatibility with filesystems that do not support this feature.

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.4.0 milestone Sep 9, 2025
@gaius-qi gaius-qi self-assigned this Sep 9, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label Sep 9, 2025
yxxhero
yxxhero previously approved these changes Sep 9, 2025
BruceAko
BruceAko previously approved these changes Sep 9, 2025
chlins
chlins previously approved these changes Sep 9, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) September 9, 2025 06:16
@gaius-qi gaius-qi dismissed stale reviews from chlins, BruceAko, and yxxhero via 1c18bb3 September 9, 2025 06:22
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.09%. Comparing base (e961c66) to head (689b90b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client-util/src/fs/mod.rs 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
- Coverage   47.10%   47.09%   -0.02%     
==========================================
  Files          60       60              
  Lines       14998    15003       +5     
==========================================
  Hits         7065     7065              
- Misses       7933     7938       +5     
Files with missing lines Coverage Δ
dragonfly-client-util/src/fs/mod.rs 60.00% <0.00%> (-20.00%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit af354b7 into main Sep 9, 2025
7 checks passed
@chlins chlins deleted the feature/fallocate branch September 9, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants