-
Notifications
You must be signed in to change notification settings - Fork 41
fix(fs): handle unsupported fallocate errors gracefully #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gaius <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
350a4e6
to
1c18bb3
Compare
Signed-off-by: Gaius <[email protected]>
1c18bb3
to
689b90b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
- Coverage 47.10% 47.09% -0.02%
==========================================
Files 60 60
Lines 14998 15003 +5
==========================================
Hits 7065 7065
- Misses 7933 7938 +5
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This pull request makes minor updates to the workspace versioning and improves filesystem compatibility in the project.
Version updates:
Cargo.toml
from1.0.16
to1.0.17
, and updated all internal dependencies to use the new version for consistency. [1] [2]Filesystem compatibility:
fallocate
function indragonfly-client-util/src/fs/mod.rs
to gracefully handle unsupported fallocate operations by logging a warning and skipping preallocation, improving compatibility with filesystems that do not support this feature.Related Issue
Motivation and Context
Screenshots (if appropriate)