-
Notifications
You must be signed in to change notification settings - Fork 41
feat: add the request sdk in dragonfly-client-util #1333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chlins
wants to merge
1
commit into
main
Choose a base branch
from
feat/request-sdk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
+ Coverage 46.90% 49.58% +2.67%
==========================================
Files 60 63 +3
Lines 15061 15936 +875
==========================================
+ Hits 7065 7902 +837
- Misses 7996 8034 +38
🚀 New features to boost your workflow:
|
b35921e
to
19e987f
Compare
gaius-qi
requested changes
Sep 9, 2025
13c5c6d
to
4cea5a6
Compare
gaius-qi
requested changes
Sep 10, 2025
453202b
to
3ea6df6
Compare
gaius-qi
requested changes
Sep 11, 2025
Signed-off-by: chlins <[email protected]>
3ea6df6
to
72e8a85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the
dragonfly-client-util
crate, focusing on expanding its functionality and improving error handling. The main changes include the addition of new modules (request
andselector
), a comprehensive error handling system for request operations, and several new dependencies to support these features.New modules and error handling:
request
andselector
todragonfly-client-util/src/lib.rs
, laying the groundwork for extended request handling and selection logic.dragonfly-client-util/src/request/errors.rs
, including a newError
enum and detailed error types (BackendError
,ProxyError
,DfdaemonError
) for distinguishing between different failure scenarios in client operations.Dependency updates:
Cargo.toml
(such astonic
,reqwest-middleware
,futures
,thiserror
,bytes
,protobuf
,hashring
,tonic-health
,local-ip-address
,hostname
,dashmap
, and new dev-dependencies for testing/mocking), enabling gRPC support, advanced HTTP handling, error management, and improved testing capabilities.reqwest
dependency from the main[dependencies]
section to the workspace-managed section for better dependency management.Description
Related Issue
Motivation and Context
Screenshots (if appropriate)