-
Notifications
You must be signed in to change notification settings - Fork 8
Adding 'Code Editor 2' theme file and related install instructions to INSTALL.md #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 Walkthrough""" WalkthroughA new Dracula color theme file for GameMaker has been introduced, providing detailed color and style definitions for various syntax scopes. Additionally, the installation documentation for all supported platforms has been updated to include instructions on installing this theme in the Code Editor 2 (Beta). Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GameMaker Editor
participant Preferences/Settings
User->>GameMaker Editor: Open Code Editor 2 (Beta)
User->>Preferences/Settings: Navigate to Preferences/Settings
User->>Preferences/Settings: Select Theme option
User->>Preferences/Settings: Choose "Create new theme from file"
User->>Preferences/Settings: Select Dracula.tmTheme
Preferences/Settings-->>GameMaker Editor: Apply Dracula color scheme
GameMaker Editor-->>User: Display editor with Dracula theme
""" 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
Dracula.tmTheme (2)
1-1
: Remove BOM from XML header
The leading invisible character before<?xml
indicates a Byte Order Mark. Some plist parsers may fail on BOM-prefixed files. Please save without BOM to ensure compatibility.
128-136
: Avoid duplicate entry name for placeholder escapes
You have two entries named “String Escape Characters” (scopesconstant.character.escape
andconstant.other.placeholder
). Consider renaming the second to something like “Placeholder Escape” to improve clarity.INSTALL.md (1)
17-24
: Unify heading casing and link formatting
The optional Code Editor 2 sections use inconsistent “Install instructions” casing across OS blocks and plain URLs. For consistency:
- Capitalize “Install Instructions” to match main headings.
- Use markdown link syntax (e.g.,
[master.zip](https://github.com/…)
) for readability.Also applies to: 40-47, 62-68
bad paste in code editor, didn't fully review originally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed some bad pasted xml properties originally, removed those
Looks good to me 👍 |
No description provided.