[maccatalyst] New signed test app for MacCatalyst (System.Collections.NonGeneric.Tests)
#1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matouskozak
added
apple
matouskozak
force-pushed
the
add-new-maccatalyst-test-apps
branch
from
60a4c97 to
667efe2
Compare
matouskozak
force-pushed
the
add-new-maccatalyst-test-apps
branch
2 times, most recently
from
4131e54 to
6fe89f7
Compare
3 tasks
|
Can we just remove the |
Sure, I can remove it here if that's preferred.
It does as well, that one is going to be replaced with the same app but signed. The replacement happens at the storage level so no need for change in xharness codebase. |
|
Closing in favor of #1368 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On newer macOS version, MacCatalyst apps must be signed to be able tu run.
In this PR, we add a new signed test app,
System.Collections.NonGeneric.Tests.apptaken from dotnet/runtime CI and compressed usingtar -czfto create a gzip archive. The compressed archive is uploaded asSystem.Collections.NonGeneric.Tests.app.zipto the remote storage.Removing the old app
maccatalyst-System.AppContext.Tests.appas there isn't 1:1 signed replacement which we could use after we migrate to newer osx queues.#1376