[browser] upgrade npm dependencies #119995
Open
+812
−909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
pavelsavara
force-pushed
the
browser_npm_dependencies
branch
from
59e9952 to
21f7d51
Compare
This was referenced Sep 24, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades npm dependencies for the browser runtime component, updating various development and production dependencies to their latest versions. The upgrade also addresses TypeScript/ESLint compatibility issues that arose from the dependency updates.
- Updated multiple npm packages including TypeScript, ESLint, Rollup, and various plugins
- Added type cast annotations to resolve TypeScript compilation errors
- Added ESLint disable comments for duplicate enum values to maintain backward compatibility
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/mono/browser/runtime/package.json | Updated npm dependencies and added cross-spawn override |
| src/mono/browser/runtime/marshal.ts | Added ESLint disable comment for duplicate enum values |
| src/mono/browser/runtime/jiterpreter.ts | Added type cast and removed unnecessary semicolon |
| src/mono/browser/runtime/jiterpreter-support.ts | Removed unnecessary semicolon in empty catch block |
| src/mono/browser/runtime/jiterpreter-jit-call.ts | Added type cast and removed unnecessary semicolon |
| src/mono/browser/runtime/jiterpreter-interp-entry.ts | Added type cast and removed unnecessary semicolon |
| src/mono/browser/runtime/interp-pgo.ts | Updated parameter type annotation |
| src/mono/browser/runtime/diagnostics/common.ts | Added type cast for Blob constructor |
| src/mono/browser/runtime/diagnostics/client-commands.ts | Added ESLint disable comment for duplicate enum values |
| } | ||
|
|
||
| export async function storeCacheEntry (cacheKey: string, memory: ArrayBuffer, mimeType: string): Promise<boolean> { | ||
| export async function storeCacheEntry (cacheKey: string, memory: Uint8Array<ArrayBuffer>, mimeType: string): Promise<boolean> { |
There was a problem hiding this comment.
The type annotation Uint8Array<ArrayBuffer> is incorrect. Uint8Array doesn't take a generic type parameter. It should be either Uint8Array or ArrayBuffer depending on the intended usage.
Suggested change
| export async function storeCacheEntry (cacheKey: string, memory: Uint8Array<ArrayBuffer>, mimeType: string): Promise<boolean> { | |
| export async function storeCacheEntry (cacheKey: string, memory: Uint8Array, mimeType: string): Promise<boolean> { |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.