unify rva checks #118936
Merged
unify rva checks #118936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
jkotas
reviewed
Aug 20, 2025
jkotas
reviewed
Aug 20, 2025
jkotas
reviewed
Aug 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR unifies RVA (Relative Virtual Address) validation checks in the PE decoder implementation by standardizing how section boundaries are calculated and validated. The changes address inconsistencies between mapped and unmapped PE file handling.
Key changes:
- Removes alignment padding from virtual size calculations in
RvaToSection - Adds explicit raw data boundary checks for unmapped images
- Removes outdated commented code and comments
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118546 (comment)