Skip to content

Conversation

kg
Copy link
Member

@kg kg commented Aug 18, 2025

Addresses #117774 and #117062

Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@kg kg marked this pull request as ready for review August 18, 2025 20:50
@Copilot Copilot AI review requested due to automatic review settings August 18, 2025 20:50
@kg kg requested review from BrzVlad and janvorli as code owners August 18, 2025 20:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates interpreter stack maps from a global thread-local cache to being managed per-compiler instance, and replaces usage of the CORINFO_FLG_CONTAINS_GC_PTR flag with direct stack map slot count checks. This addresses issues #117774 and #117062 related to interpreter stack map management.

Key changes:

  • Removes global thread-local stack map lookup cache and associated helper function
  • Moves stack map management into the InterpCompiler class as an instance member
  • Replaces CORINFO_FLG_CONTAINS_GC_PTR flag checks with stack map slot count comparisons

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/coreclr/interpreter/stackmap.h Removes global GetInterpreterStackMap function declaration
src/coreclr/interpreter/stackmap.cpp Removes thread-local cache and global helper function implementation
src/coreclr/interpreter/compileropt.cpp Adds stackmap include and updates GC pointer detection logic
src/coreclr/interpreter/compiler.h Adds stack map cache member and method declaration to InterpCompiler
src/coreclr/interpreter/compiler.cpp Implements instance-based stack map management and updates all call sites

@kg kg marked this pull request as draft August 18, 2025 20:51
Add optional ValueDestroyCallback ctor arg to dn_simdhash_ptr_ptr_holder
@kg kg merged commit 749340b into dotnet:main Aug 20, 2025
94 of 96 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants