Skip to content

Conversation

jkoritzinsky
Copy link
Member

Fixes #112419

Let's see if we break anything

@Copilot Copilot AI review requested due to automatic review settings August 18, 2025 19:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the native build configuration to use C++17 as the compiler standard level instead of C++11. This change enables the use of modern C++17 language features and standard library components throughout the native codebase.

Key changes:

  • Updates CMAKE_CXX_STANDARD from 11 to 17 in the native build configuration

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 18, 2025
@am11
Copy link
Member

am11 commented Aug 19, 2025

A few TODOs:

  • add_definitions(-DRAPIDJSON_HAS_CXX17=1) somewhere in src/native/corehost.
  • // TODO: templatize isManaged and use if constexpr for differences when we migrate to C++17

@jkoritzinsky
Copy link
Member Author

I'll make the rapidjson change in this PR, but I want to hold off on more in-depth changes (like the riscv one) until after the upgrade PR is in (to keep this one small)

@jkoritzinsky jkoritzinsky enabled auto-merge (squash) August 19, 2025 19:01
@jkoritzinsky jkoritzinsky merged commit bce39cc into main Aug 19, 2025
164 of 171 checks passed
@jkoritzinsky jkoritzinsky deleted the cxx-17 branch August 19, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Upgrade C++ compiler feature level to C++ 17
3 participants