-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[mono][debugger] Fix assertion when stepping #118458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes assertion failures when stepping in the Mono debugger on ARM64 by aligning the breakpoint address calculation logic with the AMD64 implementation. The changes remove the division by 4 that was causing incorrect indexing into the breakpoint addresses array.
- Removes division by 4 from the breakpoint trampoline offset calculation
- Updates array indexing to use native_offset directly instead of native_offset/4
- Eliminates assertions that required 4-byte alignment
Tagging subscribers to this area: @steveisok, @vitek-karas |
/backport to release/9.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/16783124435 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ba-g unrelated failure |
@thaystg I don't really understand why the code offset would ever not be 4 byte aligned. I thought all arm64 instructions are 4 bytes ? |
Using the same logic used on amd64.
Fixes #110016