Simplify pragma suppressions in generated regex code #118258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every generated regex output contained multiple pragma suppressions for warnings we know to be possible. We can simplify this by just suppressing all warnings in the generated code. If there is a stray warning (e.g. because of a custom analyzer), there's nothing the developer can do about it, and it can break their build if they have warnings-as-errors.
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies pragma warning suppressions in generated regex code by using a blanket warning suppression in release builds while maintaining specific suppressions in debug builds. This prevents build failures when custom analyzers introduce warnings that developers cannot address in generated code.
Key Changes
- Adds conditional compilation to use specific warning suppressions in DEBUG builds
- Uses blanket
#pragma warning disablein non-DEBUG builds to suppress all warnings
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
MihaZupan
approved these changes
Aug 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every generated regex output contained multiple pragma suppressions for warnings we know to be possible. We can simplify this by just suppressing all warnings in the generated code. If there is a stray warning (e.g. because of a custom analyzer), there's nothing the developer can do about it, and it can break their build if they have warnings-as-errors.