Improve SearchValues<string> Teddy throughput on Arm64 #118110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtractNarrowingSaturate
andUnzipEven
are very similar in this case, butUnzipEven
is a bit cheaper (better searching throughput).UnzipEven
may lead to more false positive matches of the anchor characters (some non-ASCII chars will look like matching ASCII ones), but we'll rule those out in the verification step if we happen to hit that on all 3 chars. Since we're only using the Teddy aproach if all anchor chars are ASCII, this seems like a good tradeoff.From Cobalt 100