[release/10.0-preview7] [Json] JsonSerializer+PipeReader support #117906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BrennanConroy
added
the
Servicing-consider
This was referenced Jul 22, 2025
jeffhandley
approved these changes
Jul 22, 2025
artl93
added
Servicing-approved
|
/ba-g illink error is known and fixed #117916 |
tarekgh
approved these changes
Jul 22, 2025
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #116947 to release/10.0-preview7
/cc @BrennanConroy
Customer Impact
Finishes up the work described in #68586. We did the first half of it last year for 9.0, and are completing the second half this year for 10.0.
Would like to get this merged into preview7, then update ASP.NET Core to make use of the new APIs and get further customer verification that everything works as expected.
Regression
Testing
Added the new APIs to the existing suite of Json tests so it should have nearly equivalent testing surface area as the existing APIs. Additionally, did manual fuzz testing on both the existing and new APIs to verify equivalent behavior. Fuzzing will be added to automation next.
Side-note: Fuzzing did find multiple bugs in STJ code both used by the new code and in the pre-existing code. Fixes have been merged already.
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low.
The change mostly does not change existing code, in order to make use of the change you need to call new methods. I've done dozens of hours of fuzz testing on both the existing and new APIs and have high confidence that this change doesn't break any existing code. The testing also gives high confidence in the new APIs, and the only differences that I'm now aware of are JsonException cases not quite lining up on the
LineNumber,BytePositionInLine, and/orPathproperties which I would consider very minor bugs.