Merging internal commits for release/8.0 #117440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated PCA of DAC cert ---- #### AI description (iteration 1) #### PR Classification Certificate update for diagnostic file signing. #### PR Summary This pull request updates the certificate issuer used for signing diagnostic files to the new PCA certificate. - `/eng/pipelines/coreclr/templates/sign-diagnostic-files.yml`: Changed the issuer check from "Microsoft Code Signing PCA 2010" to "Microsoft Code Signing PCA 2024". <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…-merge-8.0-2025-07-08-1423
There was a problem hiding this comment.
Pull Request Overview
Merging internal commits for release/8.0 to update the diagnostic file signing pipeline.
- Updated the expected certificate issuer from Microsoft Code Signing PCA 2010 to Microsoft Windows Code Signing PCA 2024.
- Adjusted the pipeline template to reflect the new certificate trust chain.
Comments suppressed due to low confidence (1)
eng/pipelines/coreclr/templates/sign-diagnostic-files.yml:72
- The new issuer DistinguishedName omits the locality (L) and state (S) fields; if the actual certificate still includes those attributes, the comparison will always fail. Please verify the exact issuer DN of the updated signing certificate and include all required components.
-or $signingCert.Issuer -ne "CN=Microsoft Windows Code Signing PCA 2024, O=Microsoft Corporation, C=US")
|
/ba-g the failure is timeout which seems unrelated or infra issue. |
tarekgh
approved these changes
Jul 9, 2025
This was referenced Aug 5, 2025
Closed
Closed
Closed
This was referenced Aug 7, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.