Revert 114347 + MSBuild tasks leak workaround + HotReload workaround #114643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rastruct…" This reverts commit b28005d.
pavelsavara
added
arch-wasm
pavelsavara
changed the title
There was a problem hiding this comment.
Copilot reviewed 1 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (6)
- src/libraries/System.Runtime.Loader/tests/System.Runtime.Loader.Tests.csproj: Language not supported
- src/libraries/tests.proj: Language not supported
- src/mono/browser/build/WasmApp.InTree.CI.targets: Language not supported
- src/mono/browser/build/WasmApp.InTree.targets: Language not supported
- src/tests/FunctionalTests/WebAssembly/Browser/HotReload/ApplyUpdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj: Language not supported
- src/tests/FunctionalTests/WebAssembly/Browser/HotReload/WebAssembly.Browser.HotReload.Test.csproj: Language not supported
This was referenced Apr 14, 2025
ilonatommy
approved these changes
Apr 15, 2025
maraf
reviewed
Apr 15, 2025
...ssembly/Browser/HotReload/ApplyUpdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj
Outdated
Show resolved
Hide resolved
...ssembly/Browser/HotReload/ApplyUpdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj
Outdated
Show resolved
Hide resolved
…pdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj Co-authored-by: Marek Fišera <[email protected]>
…pdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj Co-authored-by: Marek Fišera <[email protected]>
maraf
approved these changes
Apr 15, 2025
Open
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenerateDepsFileValidateAssembliesTaskResolveRuntimePackAssetsHotReloadtests on linux - with ActiveIssue