Revert disabling of tests for HTTP servers #114196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#111235)" This reverts commit de8e135.
…ewebsites.net (dotnet#111354)" This reverts commit 9fea441.
ghost
added
the
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the changes that disabled several HTTP server tests, restoring them by reverting to the original server configurations and re-enabling tests previously marked with ActiveIssue attributes.
- Updated HTTP server URIs in tests to reference RemoteHttp11Server instead of RemoteSecureHttp11Server.
- Removed ActiveIssue attributes to re-enable previously skipped tests.
- Restored test data in configuration files to include external server endpoints.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs | Updated server URI for HTTP/1.1 tests. |
| src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/WinHttpHandlerTest.cs | Modified server URIs and request formatting for consistency. |
| src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/ServerCertificateTest.cs | Removed ActiveIssue attribute to re-enable the test. |
| src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs | Removed ActiveIssue attribute to re-enable the test. |
| src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.RemoteServer.cs | Updated server URIs for tests and adjusted assertions accordingly. |
| src/libraries/Common/tests/System/Net/Configuration.WebSockets.cs | Restored Echo server arrays by uncommenting removed test endpoints. |
| src/libraries/Common/tests/System/Net/Configuration.Http.cs | Updated server lists to include appropriate test endpoints. |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @dotnet/ncl |
ManickaP
approved these changes
Apr 3, 2025
This was referenced Apr 3, 2025
|
HTTP outerloop tests are passing, good to merge |
|
/backport to release/8.0-staging |
|
/backport to release/9.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14243045845 |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14243048694 |
|
@rzikm backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Revert "Disable tests using http://corefx-net-http11.azurewebsites.net (#111235)"
Using index info to reconstruct a base tree...
M src/libraries/Common/tests/System/Net/Configuration.Http.cs
M src/libraries/Common/tests/System/Net/Configuration.WebSockets.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/Common/tests/System/Net/Configuration.WebSockets.cs
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Net/Configuration.WebSockets.cs
Auto-merging src/libraries/Common/tests/System/Net/Configuration.Http.cs
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Net/Configuration.Http.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Revert "Disable tests using http://corefx-net-http11.azurewebsites.net (#111235)"
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110578.
Restore previously disabled tests that depend on http://corefx-net-http11.azurewebsites.net.