WIP: Initial work to support renaming files to match types inside in bulk #80246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Sep 11, 2025
| { | ||
| cancellationToken.ThrowIfCancellationRequested(); | ||
| previewItems.Add(new SolutionPreviewItem(documentId.ProjectId, documentId, async c => | ||
| await CreateChangedDocumentPreviewViewAsync(oldSolution.GetRequiredDocument(documentId), newSolution.GetRequiredDocument(documentId), zoomLevel, c).ConfigureAwaitRunInline())); | ||
| } | ||
|
|
||
| foreach (var documentId in allChangedDocuments) |
There was a problem hiding this comment.
this was needed as otherwise we woudln't show the preview window if only renaming a file. which means there was no place to invoke 'fix all in ...'
There was a problem hiding this comment.
Please document this scenario. Also, are there any other changes to a document that should be considered other than name?
JoeRobich
reviewed
Sep 12, 2025
| @@ -90,13 +91,34 @@ internal abstract class AbstractPreviewFactoryService<TDifferenceViewer>( | |||
| var newProject = projectChanges.NewProject; | |||
|
|
|||
| // Exclude changes to unchangeable documents if they will be ignored when applied to workspace. | |||
| foreach (var documentId in projectChanges.GetChangedDocuments(onlyGetDocumentsWithTextChanges: true, ignoreUnchangeableDocuments)) | |||
| var allChangedDocuments = projectChanges.GetChangedDocuments(onlyGetDocumentsWithTextChanges: false, ignoreUnchangeableDocuments: false).ToHashSet(); | |||
There was a problem hiding this comment.
Why would we not use ignoreUnchangeableDocuments here? Can we update filename even if the document is unchangeable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.