Fixes one of the cases in directive attribute completion #11896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have @ symbol in front of existing = symbol in an attribute, we weren't getting directive attributes in the completion. We are adding one more case to check to AdjustSyntaxNodeForWordBoundary to fix this.
davidwengier
approved these changes
May 27, 2025
DustinCampbell
approved these changes
May 27, 2025
This was referenced Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have @ symbol in front of existing = symbol in an attribute, we weren't getting directive attributes in the completion. We are adding one more case to check to AdjustSyntaxNodeForWordBoundary to fix this.
### Summary of the changes
-This is another case where replacing Locate with FindInnermostNode caused an issue in one of the edge cases. If you already have an existing @="" attribute and you tried typing after @, you didn't get any of the directive attributes, e.g. @OnClick. This PR adds anothe adjustment to account for this case.
Fixes:
#11890