-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Update to wix5 #62885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update to wix5 #62885
Changes from 8 commits
Commits
Show all changes
108 commits
Select commit
Hold shift + click to select a range
46fcb7f
Initial commit for wix5 update
wtgodbe 8ba1613
Syntax error
wtgodbe 61a709f
Update wixproj's
wtgodbe 3e19f3f
Acquire wix sdk
wtgodbe 68871e0
Fix d.b.p/t
wtgodbe c6351d2
More ordering stuff
wtgodbe 7b55a21
Get rid of superfluous import
wtgodbe 699e324
Another import removed
wtgodbe 381647d
Custom SDK import
wtgodbe 69ddc01
Another double import
wtgodbe 045f463
Fix hint paths
wtgodbe 21e8c19
Who needs extensions?
wtgodbe f22d06f
Switch target
wtgodbe 7f377c4
Remove dead switch
wtgodbe 55ab66b
A couple StandardDirectory fixes
wtgodbe 7063711
Merge branch 'wtgodbe/Wix5' of https://github.com/dotnet/aspnetcore i…
wtgodbe 343e522
Small fix
wtgodbe f740bbd
Back to dir
wtgodbe fee654b
Typo
wtgodbe 7deda65
Formatting
wtgodbe cfa8ab7
More formatting
wtgodbe 1f28613
No var.
wtgodbe b8fc724
Platform -> InstallerPlatform
wtgodbe f43f04d
No StandardDirectory
wtgodbe 484247b
Fixups
wtgodbe f2d61eb
Remove unneeded compiles
wtgodbe 34a1c5b
Set Scope
wtgodbe 382e24c
Ref
wtgodbe c1bd159
Modularize it
wtgodbe bf6489d
Casing
wtgodbe fd65c7d
No Var for artifactsdir
wtgodbe 058cec6
Set GUID
wtgodbe ba57e4e
Move the component into the feature
wtgodbe 93beadb
Generate GUIDs for ANCM DepProviders
wtgodbe 0e8e279
Cheeky workaround
wtgodbe d3fd491
Revert "Cheeky workaround"
wtgodbe 4479321
Some formatting
wtgodbe e78c655
NoWarn
wtgodbe d5342d2
Fix nowarn
wtgodbe 5060052
Merge remote-tracking branch 'upstream/main' into wtgodbe/Wix5
wtgodbe f297441
Suppress StandardDirectory warning
wtgodbe 254ae86
Temporarily disable wixpack generation, see what explodes
wtgodbe 39ac32a
Cleanup for nupkg script
wtgodbe 295818e
Disable wixpack for testing
wtgodbe a38d854
StandardDir
wtgodbe 9979d19
Wixpack again
wtgodbe aea3ead
Fix upgrade policy
wtgodbe 3e7a5cf
Temporarily update Arcade
wtgodbe ce6b30b
Fix prop name
wtgodbe ef9531e
New params
wtgodbe e058292
Remove dupes
wtgodbe 1cd8b46
Exclude wxl's
wtgodbe b53e918
Resolve conflicts
wtgodbe d91a202
No var.
wtgodbe 3c4c0fa
Split ifs
wtgodbe d523d45
Set BindName
wtgodbe 6f9cd8d
Resolve conflicts
wtgodbe d17879f
Manual arcade bump
wtgodbe 416fced
Add payloads
wtgodbe ac25bc7
Merge branch 'main' into wtgodbe/Wix5
wtgodbe ef60e85
Rename file
wtgodbe b04bc07
Update ref
wtgodbe fc5a2ef
Update theme
wtgodbe d9515b3
Add files
wtgodbe ba9701a
Fixup
wtgodbe da62b97
Shorter name
wtgodbe 67761f3
Try no options
wtgodbe acc5a6e
Upload unsigned bundle
wtgodbe 924f19f
Revert "Upload unsigned bundle"
wtgodbe d330209
Revert "Try no options"
wtgodbe 1670598
Revert "Shorter name"
wtgodbe fcf1b51
Don't rename it
wtgodbe da99fb6
Try this
wtgodbe c5206c7
More
wtgodbe 41db66d
Revert "More"
wtgodbe 4b6984e
Revert "Try this"
wtgodbe d6c0584
Revert "Don't rename it"
wtgodbe 52e5920
Try something
wtgodbe 20a5fb6
Remove default
wtgodbe 8b91969
Use GenerateFiles
wtgodbe 298e31f
Fixup
wtgodbe bf1f717
Fix extensions
wtgodbe 64bf2a9
UI Improvements
wtgodbe 32ea7a4
Merge remote-tracking branch 'upstream/main' into wtgodbe/Wix5
wtgodbe 0067a3b
More alignment
wtgodbe d9e176c
A few more
wtgodbe 71246f7
Fixup
wtgodbe 7165a28
UI fixes
wtgodbe 4e41b19
Update aspnetcore runtime bundle
wtgodbe 6c56d81
Update src/Installers/Windows/Wix.targets
wtgodbe e135d86
No iswin64
wtgodbe 2191f2a
Some feedback
wtgodbe b254e41
Feedback, KeyPath
wtgodbe e179a7d
Fixup
wtgodbe fb627d3
No need for ProductVersion
wtgodbe 73b3644
Update non-english theme files
wtgodbe b91f2e0
Update bundleproj
wtgodbe 1ecfdb9
Use wix 5 in runtime bundle
wtgodbe 750dbd3
Update Arcade
wtgodbe c192a73
Stop using WixThemeVariables
wtgodbe 28e7490
Not using hyperlink license anymore
wtgodbe cff8a92
Some loc stuff
wtgodbe dde7bcb
X86 & FilesInUse
wtgodbe 684c12b
Sign less
wtgodbe 23ef642
Try new enable conditions
wtgodbe 8c9b389
NOT
wtgodbe dbbe43a
Fix signing
wtgodbe 9ca6fe6
Feedback
wtgodbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
<!-- Targets for making .wixproj better. --> | ||
<Project> | ||
<ItemDefinitionGroup> | ||
<!-- Override the MicroBuild default certs which still uses MicrosoftSHA1 and Microsoft401 --> | ||
<SignCabs> | ||
<Authenticode>Microsoft400</Authenticode> | ||
</SignCabs> | ||
<SignMsi> | ||
<Authenticode>Microsoft400</Authenticode> | ||
</SignMsi> | ||
<SignBundle> | ||
<Authenticode>Microsoft400</Authenticode> | ||
</SignBundle> | ||
<SignBundleEngine> | ||
<Authenticode>Microsoft400</Authenticode> | ||
</SignBundleEngine> | ||
</ItemDefinitionGroup> | ||
|
||
<PropertyGroup Condition="'$(OutputType)' == 'package'"> | ||
<!-- Set package version for SharedFx & TargetingPack wixproj's --> | ||
<!-- Everything built in those projects _except_ the final package & MSI are shipping assets. --> | ||
<_GeneratedPackageVersion>$(PackageVersion)</_GeneratedPackageVersion> | ||
<_GeneratedPackageVersion | ||
Condition="! $(PackageVersion.Contains('$(_PreReleaseLabel)'))">$(PackageVersion)-$(_PreReleaseLabel)$(_BuildNumberLabels)</_GeneratedPackageVersion> | ||
<!-- Insert PackageVersion into OutputName for SharedFx & TargetingPack --> | ||
<OutputName Condition="'$(OutputNamePrefix)' != '' AND '$(OutputNameSuffix)' != ''">$(OutputNamePrefix)$(_GeneratedPackageVersion)$(OutputNameSuffix)</OutputName> | ||
|
||
<EmbedCab Condition="'$(EmbedCab)' == ''">yes</EmbedCab> | ||
<InstallDir>$(ProductName)</InstallDir> | ||
|
||
<DefineConstants Condition="'$(Configuration)' == 'Debug'">$(DefineConstants);Debug</DefineConstants> | ||
<DefineConstants>$(DefineConstants);EmbedCab=$(EmbedCab)</DefineConstants> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup Condition=" '$(OutputType)' == 'package' AND '$(Cabinet)' == '' "> | ||
<Cabinet>$(OutputName.Replace('-', '_')).cab</Cabinet> | ||
<Cabinet Condition=" '$(EmbedCab)' != 'yes' ">$(OutputName.Replace('_win', '')).cab</Cabinet> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup> | ||
<Culture Condition=" '$(Culture)' == '' ">en-US</Culture> | ||
<Cultures Condition=" '$(Cultures)' == '' ">$(Culture)</Cultures> | ||
<InstallerPlatform>$(Platform)</InstallerPlatform> | ||
<OutDir Condition=" '$(OutDir)' == '' ">$(OutputPath)</OutDir> | ||
|
||
<DefineConstants>$(DefineConstants);Cabinet=$(Cabinet)</DefineConstants> | ||
<DefineConstants>$(DefineConstants);BinPath=$(OutputPath)$(Culture)\</DefineConstants> | ||
<DefineConstants>$(WixVariables);$(DefineConstants)</DefineConstants> | ||
</PropertyGroup> | ||
</Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.