Skip to content

Enhance validation for classes and records #62633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Enhance validation for classes and records #62633

merged 1 commit into from
Jul 9, 2025

Conversation

marcominerva
Copy link
Contributor

@marcominerva marcominerva commented Jul 9, 2025 •
edited
Loading

Updated ShouldTransformSymbolWithAttribute method in ValidationsGenerator.AttributeParser.cs class to support both class and record syntax nodes. Added a new test method CanValidateRecordTypesWithAttribute in ValidatableType.cs to validate record types with comprehensive scenarios for the ComplexType record.

Fixes #62315

@marcominerva
Enhance validation for classes and records
971554a 
Updated `ShouldTransformSymbolWithAttribute` to support
both class and record syntax nodes. Added a new test
method `CanValidateRecordTypesWithAttribute` in
`ValidatableType.cs` to validate record types with
comprehensive scenarios for the `ComplexType` record.
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 9, 2025
@github-actions github-actions bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Jul 9, 2025
@martincostello martincostello added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-validation Issues related to model validation in minimal and controller-based APIs and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Jul 9, 2025
@captainsafia captainsafia enabled auto-merge (squash) July 9, 2025 15:27
@build-analysis build-analysis bot mentioned this pull request Jul 9, 2025
Open
@captainsafia captainsafia merged commit d5d2a31 into dotnet:main Jul 9, 2025
29 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview7 milestone Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc community-contribution Indicates that the PR has been added by a community member feature-validation Issues related to model validation in minimal and controller-based APIs
Projects
None yet
Milestone
10.0-preview7
Development

Successfully merging this pull request may close these issues.

ValidatatableTypeAttribute does not work on records
3 participants
@marcominerva @captainsafia @martincostello