Disable PREfast in Identitymodel pipeline #62495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-infrastructure
There was a problem hiding this comment.
Pull Request Overview
This PR disables the new PREfast ruleset in the IdentityModel helix test pipeline to prevent failures caused by the updated rules.
- Added a feature flag to turn off PREfast with the new ruleset in the helix matrix.
- Ensures PREfast is only run in the main pipeline, not the test-only pipeline.
Comments suppressed due to low confidence (1)
.azure/pipelines/identitymodel-helix-matrix.yml:40
- The indentation of
featureFlagsis too shallow. It should align with thecompiledkey (same indentation level) so the YAML parser places it under the same matrix entry.
featureFlags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ruleset has been causing the pipeline to fail: https://dev.azure.com/dnceng/internal/_build/results?buildId=2738566&view=results