Skip to content

Refactoring DiagnosticDescriptors.cs files #60832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2025
Merged

Refactoring DiagnosticDescriptors.cs files #60832

merged 4 commits into from
Mar 10, 2025

Conversation

benhopkinstech
Copy link
Contributor

Description

I have refactored seven of the DiagnosticDescriptor.cs files following the points below

  • Use constants to maintain consistency between descriptors where applicable
  • Use a helper method when creating a LocalizableResourceString to make code more concise

Fixes #60831

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 9, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 9, 2025
captainsafia
captainsafia approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks for polishing things up here. 😄 ❤️ ⚡

@captainsafia captainsafia merged commit cfe55d2 into dotnet:main Mar 10, 2025
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Mar 10, 2025
@benhopkinstech benhopkinstech deleted the diagdesc branch March 10, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
10.0-preview3
Development

Successfully merging this pull request may close these issues.

Refactoring DiagnosticDescriptors.cs files
2 participants
@benhopkinstech @captainsafia