Skip to content

Conversation

benhopkinstech
Copy link
Contributor

@benhopkinstech benhopkinstech commented Mar 4, 2025

Description

  • Added some safety around accessing TypeArguments via index in DisallowNonParsableComplexTypesOnParameters.cs
  • Fixed a spelling mistake on ResolveParameterTypeSymbol
  • Removed an unused using statement in the relevant test

Fixes #60719

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 4, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 4, 2025
@benhopkinstech
Copy link
Contributor Author

@captainsafia

@captainsafia
Copy link
Member

@benhopkinstech My main hesitation with this issue is we haven't identified a syntax that would cause this that we could include in the test cases. Perhaps we can extract something from the original sample in #60719?

@benhopkinstech
Copy link
Contributor Author

Let me see if I can get the repo cloned and reproduce the error :)

@benhopkinstech benhopkinstech marked this pull request as draft March 6, 2025 18:06
@benhopkinstech benhopkinstech marked this pull request as ready for review March 10, 2025 21:58
@benhopkinstech
Copy link
Contributor Author

Please see #60719 (comment) for more details

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@captainsafia captainsafia enabled auto-merge (squash) March 10, 2025 23:28
@captainsafia captainsafia merged commit d843809 into dotnet:main Mar 11, 2025
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Mar 11, 2025
@benhopkinstech benhopkinstech deleted the 60719 branch March 11, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[10.0-preview.1] ASP.NET RouteHandlerAnalyzer - System.IndexOutOfRangeException
2 participants