Return 206 Partial Content on Valid Range for Static Assets #59160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
|
@javiercn could you merge? I don't have permissions. Thanks |
|
@melotic thanks for the contribution! |
|
@javiercn Thanks for the review + merge! This is an awesome feature. I'm not familiar with the ASP.NET Core release process, but is there any chance of a bug fix release with this PR? This is currently preventing us from enabling caching with Azure Front Door since it fetches contents in ranges. 1 The backend returns a 416 from this bug, which AFD happily forwards to clients 😢 Footnotes |
|
@melotic I'll try to bring this for the next patch release, however, bear in mind the holidays are approaching. |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/12174988321 |
11 tasks
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
…Assets (#59160) * Return 206 Partial Content on Valid Range for Static Assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, static assets returns a 416 Range Not Satisfiable when given a satisfiable range instead of a 206 Partial Content.
Fixes the bug and adds a test for it.
Fixes #58829
Additionally, the current logic doesn't return a 416 when the supplied range is unsatisfiable. I'll file a separate issue and PR.