Skip to content

[d3d8] Chrome: Gold Edition surface format shenanigans #4261

@WinterSnowfall

Description

@WinterSnowfall

Partially worked around using #4260. The game currently crashes on master since it can't create a temporary render target for the CopyRects blit, because R8G8B8 is unsupported - but that's a non-issue, because CopyRects can't handle format conversions anyway (validated part of #4217).

To reiterate here: the game's attempting to CopyRects between X8R8G8B8 and R8G8B8 surfaces, which would never work. My assumption is that it relied on hardware R8G8B8 support, which would have triggered a CopyRects path fully using R8G8B8.

Still, the above workaround makes the game fully playable for now, without any graphical artifacts of any sort.

The remaining problem is that the screenshots saved by the game alongside save games are corrupted. Below are some example save game screenshots (saved as tga originally):

The issue probably needs better handling or an actual format translation to handle the case.

Software information

Chrome 1.2.0.0/Chrome Gold (Retail)

System information

Apitrace file(s)

Game crashes when attempting to capture an apitrace.

Log files

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions