Remove .class parameters #2050
Merged
Remove .class parameters #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I've been told by @ostrolucky that it was controversial for some reason. Looking myself at the history of the issues on this repository, I think the controversy has to do with the Symfony bridge not doing the migration on their end. See #1084 if you want to go down the rabbit hole of PRs and issues. Because of that, I'll ask reviews from people more on the Symfony side this time. It's fine by me if this needs to be postponed to 4.0.0. |
greg0ire
requested review from
nicolas-grekas,
stof,
derrabus and
ostrolucky
greg0ire
force-pushed
the
remove-dot-class
branch
2 times, most recently
from
8ab5fb3 to
d8e3a36
Compare
rosier
reviewed
Sep 14, 2025
|
|
||
| $definition = $container->getDefinition('doctrine.orm.default_entity_manager'); | ||
| $this->assertEquals('%doctrine.orm.entity_manager.class%', $definition->getClass()); | ||
| $this->assertEquals('Doctrine\ORM\EntityManager', $definition->getClass()); |
There was a problem hiding this comment.
Suggested change
| $this->assertEquals('Doctrine\ORM\EntityManager', $definition->getClass()); | |
| $this->assertEquals(EntityManager::class, $definition->getClass()); |
|
|
||
| $definition = $container->getDefinition('doctrine.orm.default_entity_manager'); | ||
| $this->assertEquals('%doctrine.orm.entity_manager.class%', $definition->getClass()); | ||
| $this->assertEquals('Doctrine\ORM\EntityManager', $definition->getClass()); |
derrabus
approved these changes
Sep 16, 2025
greg0ire
force-pushed
the
remove-dot-class
branch
from
d8e3a36 to
3d9aa7e
Compare
Such parameters are supposed to be deprecated.
greg0ire
force-pushed
the
remove-dot-class
branch
from
3d9aa7e to
25efc53
Compare
derrabus
approved these changes
Sep 16, 2025
SenseException
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such parameters are supposed to be deprecated.