Python client connection pooling fix and add context manager capability to protocol #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extract base class needed by clients. - Add ai_response, ai_query - Update tests and Readme
Benchmark Results |
deven96
approved these changes
Jul 18, 2024
derhnyel
added a commit
to derhnyel/ahnlich
that referenced
this pull request
Aug 14, 2024
commit 46b65dd Author: David Onuh <[email protected]> Date: Mon Aug 12 08:58:14 2024 +0100 AIProxy Set Command Preprocessing actions for storeinputs (deven96#77) * Add a new field preprocess_action for aiproxy set command * Add preprocess_action field to python client * Add new fields for aiproxy create store commands * Update python client after changes to create store command * Remove index and query types from aiproxy create store * Update python client with changes to aiproxy create store params * - Pass preproccess actions to set command - Create base on how to edit inputtypes and convert to storekeys - Move preprocessing actions - Tie model info into aimodel - Fix fmt trait on AIStoreInputTypes * regenerate types for python client * Create ai model struct to hold info about supported models, Implement additional functions on aimodel types via traits * Cleanup and rename aistoreinputtypes * Improvements to preprocessing logic, remove &mut references commit 0325f15 Author: David Onuh <[email protected]> Date: Wed Jul 31 21:45:19 2024 +0100 Rename StoreInput and MetadataValue Variant From Binary to Image (deven96#76) * Change storeinput and metavalue variant from binary to image, remove store_type from aiproxy create_store * Fix python lib after change in types and update readme commit 44b6181 Author: David Onuh <[email protected]> Date: Wed Jul 31 19:14:06 2024 +0100 Create Rust AIProxy Client (deven96#75) * WIP: AIProxy Client - Move client's connection send and read logic to trait * Create AIproxy rust client * add some tests to rust ai proxy client * update documentation for ai proxy * add tests for aiproxy get pred command * AI and DB Conn struct rename and doc update * Add more binary store tests, Change AIProxyServer, now owns aiproxyconfig * update aiclient get pred tests and remove unnessary clone commit 6740dba Author: Diretnan Domnan <[email protected]> Date: Thu Jul 25 00:54:24 2024 +0200 Check connected clients before accepting connection (deven96#74) commit 277fda3 Author: David Onuh <[email protected]> Date: Wed Jul 24 22:44:31 2024 +0100 cleanup golang typegen (deven96#73) commit ae272ff Merge: a0766ad 6bf53d7 Author: David Onuh <[email protected]> Date: Wed Jul 24 22:13:28 2024 +0100 Merge pull request deven96#72 from deven96/diretnan/fix-persistence Fixing persistence issues from predicate index commit 6bf53d7 Author: Diretnan Domnan <[email protected]> Date: Wed Jul 24 22:51:28 2024 +0200 Fixing persistence issues from predicate index commit a0766ad Author: David Onuh <[email protected]> Date: Mon Jul 22 21:01:07 2024 +0100 AI Proxy Persistence (deven96#70) * Add persistence for ahnlich ai and add new command(destroy_database) for ai_proxy * update destroydb command to purge stores * add ai purge commands to python ai client and update readme commit 20b6c63 Author: David Onuh <[email protected]> Date: Mon Jul 22 11:35:45 2024 +0100 Add AI Proxy client (deven96#71) * seperate db client and tests from aiproxy * create ai base client and cleanup * default args cleanup * rename pool class * fleshout ai client commands * fix typespec with incomplete servertypes * update python client test workflow for aiproxy * add aiproxy tests for store commands * isolate db tests * update readme, update ai test and remove dependency on ci spinning up db and ai servers * fix typegen, trace AIStoreType * bump python client version * cleanup workflow commit c3d8f32 Author: David Onuh <[email protected]> Date: Thu Jul 18 21:11:19 2024 +0100 Python client connection pooling fix and add context manager capability to protocol (deven96#69) * utilize connection pool properly. Add ability to use protocol as a context * add formatting and linting to python actions * Refactor: Make protocol dep internal - extract base class needed by clients. - Add ai_response, ai_query - Update tests and Readme * format * fix python import path and update readme commit 5c397a1 Author: David Onuh <[email protected]> Date: Tue Jul 16 15:05:03 2024 +0100 Setup Basic AI Proxy Types (deven96#49) * Create ai-proxy query enum * Use storeinputs instead of metadatavalue * add ai server response for queries * add aiserver response * Trace ai db queries and server responses for clients * Setup entry point for ai_proxy, using db parts * WIP: moving ahnlich protocol to traits * Use traits to handle ahnlich protocol * Cleanup unused errors by ai * rename to ai instead of ahnlich_ai * Fleshing out commands * Adding dbclient to tasks * Move dbclient to aiproxy task and some cleanups * Change ai set query format * Add set command for ai proxy * Add getsimn variant * Update ai query commands to match db(create_pred_index, drop_pred_index) * Initialize reserved metadatakey * Add ai allocator and begin tests for ai * More tests for ahnlich ai proxy * remove test for unavailability * update todos and regen typespecs * Match portion of error in aiproxytests commit 94eb429 Author: David Onuh <[email protected]> Date: Tue Jul 16 15:03:49 2024 +0100 update typegen golang format (deven96#68) * update typegen format * clippy fmt * Change golang typegen format to generate mods for each file
derhnyel
added a commit
to derhnyel/ahnlich
that referenced
this pull request
Aug 14, 2024
commit eaa98e8 Author: derhnyel <[email protected]> Date: Wed Aug 14 23:29:59 2024 +0200 Squashed commit of the following: commit 46b65dd Author: David Onuh <[email protected]> Date: Mon Aug 12 08:58:14 2024 +0100 AIProxy Set Command Preprocessing actions for storeinputs (deven96#77) * Add a new field preprocess_action for aiproxy set command * Add preprocess_action field to python client * Add new fields for aiproxy create store commands * Update python client after changes to create store command * Remove index and query types from aiproxy create store * Update python client with changes to aiproxy create store params * - Pass preproccess actions to set command - Create base on how to edit inputtypes and convert to storekeys - Move preprocessing actions - Tie model info into aimodel - Fix fmt trait on AIStoreInputTypes * regenerate types for python client * Create ai model struct to hold info about supported models, Implement additional functions on aimodel types via traits * Cleanup and rename aistoreinputtypes * Improvements to preprocessing logic, remove &mut references commit 0325f15 Author: David Onuh <[email protected]> Date: Wed Jul 31 21:45:19 2024 +0100 Rename StoreInput and MetadataValue Variant From Binary to Image (deven96#76) * Change storeinput and metavalue variant from binary to image, remove store_type from aiproxy create_store * Fix python lib after change in types and update readme commit 44b6181 Author: David Onuh <[email protected]> Date: Wed Jul 31 19:14:06 2024 +0100 Create Rust AIProxy Client (deven96#75) * WIP: AIProxy Client - Move client's connection send and read logic to trait * Create AIproxy rust client * add some tests to rust ai proxy client * update documentation for ai proxy * add tests for aiproxy get pred command * AI and DB Conn struct rename and doc update * Add more binary store tests, Change AIProxyServer, now owns aiproxyconfig * update aiclient get pred tests and remove unnessary clone commit 6740dba Author: Diretnan Domnan <[email protected]> Date: Thu Jul 25 00:54:24 2024 +0200 Check connected clients before accepting connection (deven96#74) commit 277fda3 Author: David Onuh <[email protected]> Date: Wed Jul 24 22:44:31 2024 +0100 cleanup golang typegen (deven96#73) commit ae272ff Merge: a0766ad 6bf53d7 Author: David Onuh <[email protected]> Date: Wed Jul 24 22:13:28 2024 +0100 Merge pull request deven96#72 from deven96/diretnan/fix-persistence Fixing persistence issues from predicate index commit 6bf53d7 Author: Diretnan Domnan <[email protected]> Date: Wed Jul 24 22:51:28 2024 +0200 Fixing persistence issues from predicate index commit a0766ad Author: David Onuh <[email protected]> Date: Mon Jul 22 21:01:07 2024 +0100 AI Proxy Persistence (deven96#70) * Add persistence for ahnlich ai and add new command(destroy_database) for ai_proxy * update destroydb command to purge stores * add ai purge commands to python ai client and update readme commit 20b6c63 Author: David Onuh <[email protected]> Date: Mon Jul 22 11:35:45 2024 +0100 Add AI Proxy client (deven96#71) * seperate db client and tests from aiproxy * create ai base client and cleanup * default args cleanup * rename pool class * fleshout ai client commands * fix typespec with incomplete servertypes * update python client test workflow for aiproxy * add aiproxy tests for store commands * isolate db tests * update readme, update ai test and remove dependency on ci spinning up db and ai servers * fix typegen, trace AIStoreType * bump python client version * cleanup workflow commit c3d8f32 Author: David Onuh <[email protected]> Date: Thu Jul 18 21:11:19 2024 +0100 Python client connection pooling fix and add context manager capability to protocol (deven96#69) * utilize connection pool properly. Add ability to use protocol as a context * add formatting and linting to python actions * Refactor: Make protocol dep internal - extract base class needed by clients. - Add ai_response, ai_query - Update tests and Readme * format * fix python import path and update readme commit 5c397a1 Author: David Onuh <[email protected]> Date: Tue Jul 16 15:05:03 2024 +0100 Setup Basic AI Proxy Types (deven96#49) * Create ai-proxy query enum * Use storeinputs instead of metadatavalue * add ai server response for queries * add aiserver response * Trace ai db queries and server responses for clients * Setup entry point for ai_proxy, using db parts * WIP: moving ahnlich protocol to traits * Use traits to handle ahnlich protocol * Cleanup unused errors by ai * rename to ai instead of ahnlich_ai * Fleshing out commands * Adding dbclient to tasks * Move dbclient to aiproxy task and some cleanups * Change ai set query format * Add set command for ai proxy * Add getsimn variant * Update ai query commands to match db(create_pred_index, drop_pred_index) * Initialize reserved metadatakey * Add ai allocator and begin tests for ai * More tests for ahnlich ai proxy * remove test for unavailability * update todos and regen typespecs * Match portion of error in aiproxytests commit 94eb429 Author: David Onuh <[email protected]> Date: Tue Jul 16 15:03:49 2024 +0100 update typegen golang format (deven96#68) * update typegen format * clippy fmt * Change golang typegen format to generate mods for each file
derhnyel
added a commit
that referenced
this pull request
Aug 15, 2024
* Squashed commit of the following: commit 46b65dd Author: David Onuh <[email protected]> Date: Mon Aug 12 08:58:14 2024 +0100 AIProxy Set Command Preprocessing actions for storeinputs (#77) * Add a new field preprocess_action for aiproxy set command * Add preprocess_action field to python client * Add new fields for aiproxy create store commands * Update python client after changes to create store command * Remove index and query types from aiproxy create store * Update python client with changes to aiproxy create store params * - Pass preproccess actions to set command - Create base on how to edit inputtypes and convert to storekeys - Move preprocessing actions - Tie model info into aimodel - Fix fmt trait on AIStoreInputTypes * regenerate types for python client * Create ai model struct to hold info about supported models, Implement additional functions on aimodel types via traits * Cleanup and rename aistoreinputtypes * Improvements to preprocessing logic, remove &mut references commit 0325f15 Author: David Onuh <[email protected]> Date: Wed Jul 31 21:45:19 2024 +0100 Rename StoreInput and MetadataValue Variant From Binary to Image (#76) * Change storeinput and metavalue variant from binary to image, remove store_type from aiproxy create_store * Fix python lib after change in types and update readme commit 44b6181 Author: David Onuh <[email protected]> Date: Wed Jul 31 19:14:06 2024 +0100 Create Rust AIProxy Client (#75) * WIP: AIProxy Client - Move client's connection send and read logic to trait * Create AIproxy rust client * add some tests to rust ai proxy client * update documentation for ai proxy * add tests for aiproxy get pred command * AI and DB Conn struct rename and doc update * Add more binary store tests, Change AIProxyServer, now owns aiproxyconfig * update aiclient get pred tests and remove unnessary clone commit 6740dba Author: Diretnan Domnan <[email protected]> Date: Thu Jul 25 00:54:24 2024 +0200 Check connected clients before accepting connection (#74) commit 277fda3 Author: David Onuh <[email protected]> Date: Wed Jul 24 22:44:31 2024 +0100 cleanup golang typegen (#73) commit ae272ff Merge: a0766ad 6bf53d7 Author: David Onuh <[email protected]> Date: Wed Jul 24 22:13:28 2024 +0100 Merge pull request #72 from deven96/diretnan/fix-persistence Fixing persistence issues from predicate index commit 6bf53d7 Author: Diretnan Domnan <[email protected]> Date: Wed Jul 24 22:51:28 2024 +0200 Fixing persistence issues from predicate index commit a0766ad Author: David Onuh <[email protected]> Date: Mon Jul 22 21:01:07 2024 +0100 AI Proxy Persistence (#70) * Add persistence for ahnlich ai and add new command(destroy_database) for ai_proxy * update destroydb command to purge stores * add ai purge commands to python ai client and update readme commit 20b6c63 Author: David Onuh <[email protected]> Date: Mon Jul 22 11:35:45 2024 +0100 Add AI Proxy client (#71) * seperate db client and tests from aiproxy * create ai base client and cleanup * default args cleanup * rename pool class * fleshout ai client commands * fix typespec with incomplete servertypes * update python client test workflow for aiproxy * add aiproxy tests for store commands * isolate db tests * update readme, update ai test and remove dependency on ci spinning up db and ai servers * fix typegen, trace AIStoreType * bump python client version * cleanup workflow commit c3d8f32 Author: David Onuh <[email protected]> Date: Thu Jul 18 21:11:19 2024 +0100 Python client connection pooling fix and add context manager capability to protocol (#69) * utilize connection pool properly. Add ability to use protocol as a context * add formatting and linting to python actions * Refactor: Make protocol dep internal - extract base class needed by clients. - Add ai_response, ai_query - Update tests and Readme * format * fix python import path and update readme commit 5c397a1 Author: David Onuh <[email protected]> Date: Tue Jul 16 15:05:03 2024 +0100 Setup Basic AI Proxy Types (#49) * Create ai-proxy query enum * Use storeinputs instead of metadatavalue * add ai server response for queries * add aiserver response * Trace ai db queries and server responses for clients * Setup entry point for ai_proxy, using db parts * WIP: moving ahnlich protocol to traits * Use traits to handle ahnlich protocol * Cleanup unused errors by ai * rename to ai instead of ahnlich_ai * Fleshing out commands * Adding dbclient to tasks * Move dbclient to aiproxy task and some cleanups * Change ai set query format * Add set command for ai proxy * Add getsimn variant * Update ai query commands to match db(create_pred_index, drop_pred_index) * Initialize reserved metadatakey * Add ai allocator and begin tests for ai * More tests for ahnlich ai proxy * remove test for unavailability * update todos and regen typespecs * Match portion of error in aiproxytests commit 94eb429 Author: David Onuh <[email protected]> Date: Tue Jul 16 15:03:49 2024 +0100 update typegen golang format (#68) * update typegen format * clippy fmt * Change golang typegen format to generate mods for each file * feat: add publich test file * refactor: update GitHub workflow to publish test results * refactor: rename GitHub workflow file to publish_test.yml
deven96
added a commit
that referenced
this pull request
Jul 16, 2025
* Squashed commit of the following: commit 46b65dd Author: David Onuh <[email protected]> Date: Mon Aug 12 08:58:14 2024 +0100 AIProxy Set Command Preprocessing actions for storeinputs (#77) * Add a new field preprocess_action for aiproxy set command * Add preprocess_action field to python client * Add new fields for aiproxy create store commands * Update python client after changes to create store command * Remove index and query types from aiproxy create store * Update python client with changes to aiproxy create store params * - Pass preproccess actions to set command - Create base on how to edit inputtypes and convert to storekeys - Move preprocessing actions - Tie model info into aimodel - Fix fmt trait on AIStoreInputTypes * regenerate types for python client * Create ai model struct to hold info about supported models, Implement additional functions on aimodel types via traits * Cleanup and rename aistoreinputtypes * Improvements to preprocessing logic, remove &mut references commit 0325f15 Author: David Onuh <[email protected]> Date: Wed Jul 31 21:45:19 2024 +0100 Rename StoreInput and MetadataValue Variant From Binary to Image (#76) * Change storeinput and metavalue variant from binary to image, remove store_type from aiproxy create_store * Fix python lib after change in types and update readme commit 44b6181 Author: David Onuh <[email protected]> Date: Wed Jul 31 19:14:06 2024 +0100 Create Rust AIProxy Client (#75) * WIP: AIProxy Client - Move client's connection send and read logic to trait * Create AIproxy rust client * add some tests to rust ai proxy client * update documentation for ai proxy * add tests for aiproxy get pred command * AI and DB Conn struct rename and doc update * Add more binary store tests, Change AIProxyServer, now owns aiproxyconfig * update aiclient get pred tests and remove unnessary clone commit 6740dba Author: Diretnan Domnan <[email protected]> Date: Thu Jul 25 00:54:24 2024 +0200 Check connected clients before accepting connection (#74) commit 277fda3 Author: David Onuh <[email protected]> Date: Wed Jul 24 22:44:31 2024 +0100 cleanup golang typegen (#73) commit ae272ff Merge: a0766ad 6bf53d7 Author: David Onuh <[email protected]> Date: Wed Jul 24 22:13:28 2024 +0100 Merge pull request #72 from deven96/diretnan/fix-persistence Fixing persistence issues from predicate index commit 6bf53d7 Author: Diretnan Domnan <[email protected]> Date: Wed Jul 24 22:51:28 2024 +0200 Fixing persistence issues from predicate index commit a0766ad Author: David Onuh <[email protected]> Date: Mon Jul 22 21:01:07 2024 +0100 AI Proxy Persistence (#70) * Add persistence for ahnlich ai and add new command(destroy_database) for ai_proxy * update destroydb command to purge stores * add ai purge commands to python ai client and update readme commit 20b6c63 Author: David Onuh <[email protected]> Date: Mon Jul 22 11:35:45 2024 +0100 Add AI Proxy client (#71) * seperate db client and tests from aiproxy * create ai base client and cleanup * default args cleanup * rename pool class * fleshout ai client commands * fix typespec with incomplete servertypes * update python client test workflow for aiproxy * add aiproxy tests for store commands * isolate db tests * update readme, update ai test and remove dependency on ci spinning up db and ai servers * fix typegen, trace AIStoreType * bump python client version * cleanup workflow commit c3d8f32 Author: David Onuh <[email protected]> Date: Thu Jul 18 21:11:19 2024 +0100 Python client connection pooling fix and add context manager capability to protocol (#69) * utilize connection pool properly. Add ability to use protocol as a context * add formatting and linting to python actions * Refactor: Make protocol dep internal - extract base class needed by clients. - Add ai_response, ai_query - Update tests and Readme * format * fix python import path and update readme commit 5c397a1 Author: David Onuh <[email protected]> Date: Tue Jul 16 15:05:03 2024 +0100 Setup Basic AI Proxy Types (#49) * Create ai-proxy query enum * Use storeinputs instead of metadatavalue * add ai server response for queries * add aiserver response * Trace ai db queries and server responses for clients * Setup entry point for ai_proxy, using db parts * WIP: moving ahnlich protocol to traits * Use traits to handle ahnlich protocol * Cleanup unused errors by ai * rename to ai instead of ahnlich_ai * Fleshing out commands * Adding dbclient to tasks * Move dbclient to aiproxy task and some cleanups * Change ai set query format * Add set command for ai proxy * Add getsimn variant * Update ai query commands to match db(create_pred_index, drop_pred_index) * Initialize reserved metadatakey * Add ai allocator and begin tests for ai * More tests for ahnlich ai proxy * remove test for unavailability * update todos and regen typespecs * Match portion of error in aiproxytests commit 94eb429 Author: David Onuh <[email protected]> Date: Tue Jul 16 15:03:49 2024 +0100 update typegen golang format (#68) * update typegen format * clippy fmt * Change golang typegen format to generate mods for each file * feat: add publich test file * feat: add grpc proto files * Changes to proto and workspace * Added tests for go client * uncommented python generation * uncommented python generation * Tests working * feat: add go test to actions * chore: format and lint go-files * Added warm up to tests * Removed unwanted tests * Removed warm up programmatically * feat: fix benchmark with docker image cache * feat: add readme * chore: fix lint and formatter * fix tests --------- Co-authored-by: David Eje <[email protected]> Co-authored-by: Diretnan Domnan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.