fix: partial support multi-platform build with automatic platform args #1064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fix missing platform arguments (e.g.,
$TARGETARCH
) for multi-platform builds.Key Changes
findBaseImage
function based on the CLI execution environment or--platform
args.How to Test
FROM ${TARGETARCH}-base
).src/test/configs/dockerfile-with-automatic-platform-args/
src/test/configs/dockerfile-with-inconsistent-base-image/
Related Issus
findBaseImage
in dockerfileUtils.ts does not handle buildkit automatic variables in layers name #275Note