Skip to content

Conversation

drduker
Copy link

@drduker drduker commented Jul 2, 2025

Add feature to modify displayed logo in K9s console from skins

copy of this but no one is fixing the linting so I just did.
see details here:
#3225

@drduker
Copy link
Author

drduker commented Jul 2, 2025

@derailed - please approve for workflows, thanks!

@drduker drduker mentioned this pull request Jul 2, 2025
2 tasks
@drduker
Copy link
Author

drduker commented Jul 7, 2025

@derailed approval again please

@drduker
Copy link
Author

drduker commented Jul 10, 2025

@derailed sorry, please again

@feteu
Copy link

feteu commented Aug 1, 2025

@derailed any chance of looking into this.
Many thanks already in advance. Happy to help in case something would not work out,

@drduker
Copy link
Author

drduker commented Aug 18, 2025

working on fixing now, rebased

@drduker drduker force-pushed the Feature/dynamic-logo branch from 48f86f4 to f56bcec Compare August 18, 2025 14:27
@drduker
Copy link
Author

drduker commented Aug 18, 2025

@derailed please approve workflows. There is no pre-commit file in this repo so if you like line endings to have a space almost every file would be touched. About to push up another change.

@drduker
Copy link
Author

drduker commented Aug 18, 2025

After adding local .pre-commit-config.yaml we have some trailing line-endings needed and some extra spaces in various places cleaned up. Adding a local pre-commit within the repo will help ensure confidence when someone pushes up an MR, i won't fail the pipeline.

@drduker
Copy link
Author

drduker commented Aug 18, 2025

@derailed
please approve pipelines, thank you so much!

@drduker
Copy link
Author

drduker commented Aug 18, 2025

  - id: trailing-whitespace
  - id: end-of-file-fixer
  
  both of those were run that is why so many files were touched.  But now it is cleaner!
  @derailed 

@drduker
Copy link
Author

drduker commented Aug 18, 2025

@derailed - right here thanks!

@drduker
Copy link
Author

drduker commented Aug 19, 2025

@derailed - approval pretty please

@drduker
Copy link
Author

drduker commented Aug 20, 2025

@fengye87 - can you approve the workflows?

@fengye87
Copy link
Contributor

@drduker I'm afraid I don't have the permissions

@drduker
Copy link
Author

drduker commented Aug 21, 2025

@derailed - i am so sorry I'm continuing to ping you. Hoping one of these shows up in your notifications feed.

@drduker
Copy link
Author

drduker commented Aug 22, 2025

@derailed will this work or do want some changes?

@feteu
Copy link

feteu commented Aug 23, 2025

@derailed wiuld be amazing if this could be rolled out soon. Really looking forward to this.

@drduker
Copy link
Author

drduker commented Sep 2, 2025

@derailed please approve workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants