-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: add dynamic logos #3432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add dynamic logos #3432
Conversation
@derailed - please approve for workflows, thanks! |
@derailed approval again please |
@derailed sorry, please again |
@derailed any chance of looking into this. |
working on fixing now, rebased |
48f86f4
to
f56bcec
Compare
@derailed please approve workflows. There is no pre-commit file in this repo so if you like line endings to have a space almost every file would be touched. About to push up another change. |
After adding local .pre-commit-config.yaml we have some trailing line-endings needed and some extra spaces in various places cleaned up. Adding a local pre-commit within the repo will help ensure confidence when someone pushes up an MR, i won't fail the pipeline. |
Signed-off-by: Lucas Pick <[email protected]>
@derailed |
|
@derailed - right here thanks! |
@derailed - approval pretty please |
@fengye87 - can you approve the workflows? |
@drduker I'm afraid I don't have the permissions |
@derailed - i am so sorry I'm continuing to ping you. Hoping one of these shows up in your notifications feed. |
@derailed will this work or do want some changes? |
@derailed wiuld be amazing if this could be rolled out soon. Really looking forward to this. |
@derailed please approve workflow run |
Add feature to modify displayed logo in K9s console from skins
copy of this but no one is fixing the linting so I just did.
see details here:
#3225