Skip to content

Conversation

dhelms-bw
Copy link
Contributor

@dhelms-bw dhelms-bw commented Jan 6, 2020

Proposed changes

This adds support for canary deploys with using websockets under AWS V2 API Gateways. API Gateway V2 resources with lambdas use integration resources which must be updated to execute the aliased version of a lambda during a deploy. Similarly, authenticators must also be updated to use the aliased lambda to prevent execution permissions issues.

Types of changes

What types of changes does your code introduce to the plugin?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@dhelms-bw
Copy link
Contributor Author

After seeing some additional alias permission issues brought in serverless 1.60.2 reported in #71, I'm going to test this on the latest serverless and report back if this PR holds up.

@davidgf davidgf merged commit 5444eae into davidgf:master Jan 29, 2020
@davidgf
Copy link
Owner

davidgf commented Jan 29, 2020

@dhelms-bw thank you very much for your contribution!

samcon pushed a commit to samcon/serverless-plugin-canary-deployments that referenced this pull request Sep 6, 2020
* Add api gaeway v2 support for websockets

* Add fix for v2 authorizers
@davidgf davidgf mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants