-
Notifications
You must be signed in to change notification settings - Fork 83
feat: generate deployment group name #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
module.exports.pre = (event, context, callback) => { | ||
var deploymentId = event.DeploymentId | ||
var lifecycleEventHookExecutionId = event.LifecycleEventHookExecutionId | ||
const deploymentId = event.DeploymentId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,19 +1,11055 @@ | |||
{ | |||
"name": "serverless-plugin-canary-deployments", | |||
"version": "0.4.8", | |||
"lockfileVersion": 1, | |||
"version": "0.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this 🙇
@davidgf could you take a look at this one? :) |
Thank you very much for your contribution! |
Thank you so much for this @samchungy! 🎉 🙌 |
Finally Fixed the issue of Circular Dependency... Thanks. |
Proposed changes
${stackName}-${logicalId}
to avoid a circular dependency when used with the aws-alerts plugin.npm audit fix
Resolves #127
Resolves #114
Types of changes
What types of changes does your code introduce to the plugin?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Ran on sls-canary-example repo

Before:
After:
