Patch in CodeDeploy permissions for hooks

[72636c]

Proposed changes

BeforeAllowTrafficHooks and AfterAllowTrafficHooks require access to report their status back to CodeDeploy. It's tedious and brittle to manually add these to iamRoleStatements as they rely on CloudFormation logical IDs generated by the plugin itself.

This detects which functions have a hook defined and appends permissions to report on their corresponding deployment groups.

Resolves #93.

Types of changes

What types of changes does your code introduce to the plugin?

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[72636c]

Hiya @davidgf, reckon you'll have a moment to look this over?

[davidgf]

Hey @72636c, first of all, I'm very sorry for the late reply, unfortunately for professional reasons I cannot pay all the attention I'd like to to this project. Also, thank you very much for your contribution. It looks pretty good in general, but there's something I'd like you to change if you could. Basically, all the functions under lib/CfTemplateGenerators/ don't have any side effect by design, but simply generate a piece of a CloudFormation template and return it. The service's CF template is only explicitly modified in the Object.assign() statement on the addCanaryDeploymentResources function. However, in your PR, the CF generator takes the full CF template as a parameter and directly modifies it within the scope of that function. Could you modify it so it aligns with the aforementioned approach? Thanks!

[72636c]

@davidgf no stress, thanks for the review!

Good call, I was tiptoeing around that since we're extending a fairly chunky Serverless-generated resource. I've gone with a dirty _.cloneDeep in ed78f3b; let me know if you have any better ideas.

[davidgf]

It looks good to me, thanks a lot for your contribution!