Skip to content

[Internal] Enable Apps integration tests on GCP #4825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Internal] Enable Apps integration tests on GCP #4825

wants to merge 1 commit into from

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jun 30, 2025

Changes

Apps are now available on GCP, so it makes sense to enable tests there as well

NO_CHANGELOG=true

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework
  • has entry in NEXT_CHANGELOG.md file

@alexott alexott requested review from a team as code owners June 30, 2025 10:23
@alexott alexott requested review from tanmay-db and removed request for a team June 30, 2025 10:23
@alexott alexott temporarily deployed to test-trigger-is June 30, 2025 10:23 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is June 30, 2025 10:24 — with GitHub Actions Inactive
@alexott
Copy link
Contributor Author

alexott commented Jun 30, 2025

App test fails on GCP with the error Error: cannot create model serving: Workspace Model Registry serving is deprecated. Please use Unity Catalog models for serving. We need to register experiment-fixture-model in UC as well, not only in the model registry.

@nkvuong nkvuong force-pushed the internal/apps-on-gcp-integration-test branch from 29f110f to 7678043 Compare July 4, 2025 04:53
@nkvuong nkvuong temporarily deployed to test-trigger-is July 4, 2025 04:53 — with GitHub Actions Inactive
@nkvuong nkvuong temporarily deployed to test-trigger-is July 4, 2025 04:54 — with GitHub Actions Inactive
@alexott @nkvuong
[Internal] Enable Apps integration test on GCP
5d67705 
Apps are now available on GCP, so it makes sense to enable tests there as well

NO_CHANGELOG=true
@nkvuong nkvuong force-pushed the internal/apps-on-gcp-integration-test branch from 7678043 to 5d67705 Compare August 18, 2025 04:08
@nkvuong nkvuong temporarily deployed to test-trigger-is August 18, 2025 04:08 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4825
  • Commit SHA: 5d67705e4a81f94b7b921b7e37ceef91e36554c0

Checks will be approved automatically on success.

@nkvuong nkvuong temporarily deployed to test-trigger-is August 18, 2025 04:09 — with GitHub Actions Inactive
@alexott
Copy link
Contributor Author

alexott commented Aug 18, 2025

@nkvuong we need a registered UC model to make it working on GCP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmay-db tanmay-db tanmay-db approved these changes

+1 more reviewer

@nkvuong nkvuong nkvuong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexott @nkvuong @tanmay-db