#3180. Add tests for JSDataViewToByteData and ByteDataToJSDataView
#3312
Conversation
| /// > [JSDataView] and vice versa unless it was instantiated in JavaScript. | ||
| /// | ||
| /// @description Check that on `dart2wasm` if [ByteBuffer] was instantiated in | ||
| /// JavaScript then this operations unwraps it and therefore changes in the |
There was a problem hiding this comment.
Typo:
| /// JavaScript then this operations unwraps it and therefore changes in the | |
| /// JavaScript then this operation unwraps it. Hence, changes in the |
| /// versa. | ||
| /// | ||
| /// @description Check that this getter converts this [JSDataView] to a | ||
| /// [ByteData]. Test [JSDataView] created in JavaScript. |
There was a problem hiding this comment.
Just a nit: This also tests that the original DataView is modified when modifying the ByteData.
| /// Modifications to this [JSDataView] will affect the [ByteData] and vice | ||
| /// versa. | ||
| /// | ||
| /// @description Check that in case of `dart2js` this operation is a cast and |
There was a problem hiding this comment.
Should we check this isn't the case in dart2wasm?
There was a problem hiding this comment.
At first I didn't add this because it isn't said that wrapping/unwrapping operation cannot return the same object. But in our meeting this morning, @eernstg convinced me that it's important for users to know that these are distinct objects. Updated.
| /// Modifications to this [JSDataView] will affect the [ByteData] and vice | ||
| /// versa. | ||
| /// | ||
| /// @description Check that this getter converts this [JSDataView] to a |
| /// > [JSDataView] and vice versa unless it was instantiated in JavaScript. | ||
| /// | ||
| /// @description Check that on `dart2wasm` if [ByteBuffer] was instantiated in | ||
| /// JavaScript then this operations unwraps it and therefore changes in the |
| /// Modifications to this [JSDataView] will affect the [ByteData] and vice | ||
| /// versa. | ||
| /// | ||
| /// @description Check that in case of `dart2js` this operation is a cast and |
There was a problem hiding this comment.
At first I didn't add this because it isn't said that wrapping/unwrapping operation cannot return the same object. But in our meeting this morning, @eernstg convinced me that it's important for users to know that these are distinct objects. Updated.
| /// versa. | ||
| /// | ||
| /// @description Check that this getter converts this [JSDataView] to a | ||
| /// [ByteData]. Test [JSDataView] created in JavaScript. |
| /// Modifications to this [JSDataView] will affect the [ByteData] and vice | ||
| /// versa. | ||
| /// | ||
| /// @description Check that this getter converts this [JSDataView] to a |
No description provided.