Skip to content

fix #14117: --no-check-unused-templates does not apply to templated functions with declaration specifiers #7811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix #14117: --no-check-unused-templates does not apply to templated functions with declaration specifiers #7811

wants to merge 5 commits into from

Conversation

ludviggunne
Copy link
Collaborator

No description provided.

@ludviggunne ludviggunne marked this pull request as ready for review September 10, 2025 09:00
@ludviggunne
Copy link
Collaborator Author

May need more work after #7800 and #7803, so I'm leaving it as a draft for now.

@ludviggunne ludviggunne marked this pull request as draft September 10, 2025 09:00
@firewave
Copy link
Collaborator

Seems a bit convoluted but as I do not understand this kind of processing well I leave it up to others to comment.

Still some notes.

firewave
firewave reviewed Sep 10, 2025
View reviewed changes
firewave
firewave reviewed Sep 10, 2025
View reviewed changes
firewave
firewave reviewed Sep 10, 2025
View reviewed changes
@firewave
Copy link
Collaborator

May need more work after #7800 and #7803, so I'm leaving it as a draft for now.

For some additional extended manual testing you could use the invocation added in danmar/simplecpp#438 and adjust it for Cppcheck and compare the output. The standard headers have lots of templates after all.

@ludviggunne ludviggunne mentioned this pull request Sep 10, 2025
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ludviggunne
Copy link
Collaborator Author

May need more work after #7800 and #7803, so I'm leaving it as a draft for now.

For some additional extended manual testing you could use the invocation added in danmar/simplecpp#438 and adjust it for Cppcheck and compare the output. The standard headers have lots of templates after all.

Thanks, I'll take a look at that

@firewave
Copy link
Collaborator

Not in the scope of this PR but I wonder if it would make sense to add a debug message if a function is being omitted from analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firewave firewave firewave left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludviggunne @firewave