Skip to content

Conversation

Flottegurke
Copy link
Contributor

I corrected a small typo.
(This is my first PR - I hope I did everything correctly)

@tessus
Copy link
Contributor

tessus commented Aug 17, 2025

Everything seems fine, except the title. The title suggests you replaced is on with the, which you didn't. You just removed is on. You also have a typo in the title. ;-)

I'd change the title to: fix(config): correct typo in template

P.S.: No need to change the commit message. The PRs are squashed anyway, so the title becomes the commit message.

@Flottegurke Flottegurke changed the title fix(config): correct typo in tempate ("is on" -> "the") fix(config): correct typo in tempate Aug 17, 2025
@Flottegurke Flottegurke changed the title fix(config): correct typo in tempate fix(config): correct typo in template Aug 17, 2025
@Flottegurke
Copy link
Contributor Author

OK, thanks!

@stefan0xC
Copy link
Contributor

vaultwarden/src/config.rs

Lines 779 to 780 in 77008a9

/// Server name sent during HELO |> By default this value should be is on the machine's hostname, but might need to be changed in case it trips some anti-spam filters
helo_name: String, true, option;
should also be corrected. And I would change the title of the commit to "fix typo in description of helo_name" or something like that.

fix(config): also correct typo in config.rs
@Flottegurke Flottegurke changed the title fix(config): correct typo in template fix typo in description of helo_name Aug 17, 2025
@Flottegurke
Copy link
Contributor Author

Oh, I missed that. I think I've fixed it now.

Copy link
Owner

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@dani-garcia dani-garcia merged commit 1f73630 into dani-garcia:main Aug 20, 2025
8 checks passed
rossigee pushed a commit to rossigee/vaultwarden that referenced this pull request Sep 7, 2025
fix(config): also correct typo in config.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants