Proper support for shell input #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kpenfound <[email protected]> assemble dagger command in new step with output Signed-off-by: kpenfound <[email protected]> fixing some inline bash Signed-off-by: kpenfound <[email protected]> wrap conditional inputs in quotes Signed-off-by: kpenfound <[email protected]> use cat for heredoc script file Signed-off-by: kpenfound <[email protected]> missing space in heredoc Signed-off-by: kpenfound <[email protected]> add tab ignore and dagger shebang Signed-off-by: kpenfound <[email protected]> use toJson and jq to safely write the shell input to a file Signed-off-by: kpenfound <[email protected]> put DAGGER_COMMAND in a variable Signed-off-by: kpenfound <[email protected]> missing semicolon for the dagger command Signed-off-by: kpenfound <[email protected]> safely evaluate if shell is set Signed-off-by: kpenfound <[email protected]> extra > in shell file write Signed-off-by: kpenfound <[email protected]> add some logging Signed-off-by: kpenfound <[email protected]> strip extra newline from jq when shell is not set Signed-off-by: kpenfound <[email protected]> debugging Signed-off-by: kpenfound <[email protected]> toJSON and jq will send null instead of empty string with no input Signed-off-by: kpenfound <[email protected]> safely handle all inputs Signed-off-by: kpenfound <[email protected]> did i fix the wrong thing? Signed-off-by: kpenfound <[email protected]> change up the approach a bit for an easier diff Signed-off-by: kpenfound <[email protected]> fix shell test Signed-off-by: kpenfound <[email protected]> single quotes around shell input Signed-off-by: kpenfound <[email protected]> try with piped input Signed-off-by: kpenfound <[email protected]> try single quotes again Signed-off-by: kpenfound <[email protected]> debug Signed-off-by: kpenfound <[email protected]> debug Signed-off-by: kpenfound <[email protected]> fix shell test Signed-off-by: kpenfound <[email protected]> does shell emit a newline? Signed-off-by: kpenfound <[email protected]> remove the trailing newline if its in stdout Signed-off-by: kpenfound <[email protected]> break the trailing output test Signed-off-by: kpenfound <[email protected]> fix shell test Signed-off-by: kpenfound <[email protected]> missed ! Signed-off-by: kpenfound <[email protected]> add comment about weird test Signed-off-by: kpenfound <[email protected]>
jedevc
reviewed
Sep 16, 2025
.github/workflows/test.yml
Outdated
| run: | | ||
| target='${{ steps.test-shell.outputs.output }}' | ||
| result='hello world! | ||
| ' # shell appears to emit an extra newline compared to call |
There was a problem hiding this comment.
Ah, I suspect this is because echo includes a newline (while the call to shykes/daggerverse just directly returns a string without the newline).
We could either use the same test for both, or just use -n on the echo.
There was a problem hiding this comment.
ah let me try with -n
jedevc
reviewed
Sep 16, 2025
| version: "latest" # semver x.y.z | ||
| ``` | ||
| ### `dagger shell` |
There was a problem hiding this comment.
We could make this the first option?
There was a problem hiding this comment.
maybe, i suspect call will still be the standard approach in ci configurations because of the named args
jedevc
approved these changes
Sep 16, 2025
Signed-off-by: kpenfound <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180