Skip to content

Conversation

kpenfound
Copy link
Contributor

@kpenfound kpenfound commented Sep 15, 2025

Fixes #164

This is a breaking change for workflows that rely on the action to install multiple versions of dagger in a single job, but is the most direct approach to make it work out of the box for runners with dagger pre-installed like on depot

@kpenfound kpenfound requested review from jedevc and matipan September 15, 2025 19:00
@jedevc
Copy link
Member

jedevc commented Sep 16, 2025

SGTM, but I think we could maybe avoid an error if the version if the right version of dagger is already installed?

@kpenfound
Copy link
Contributor Author

kpenfound commented Sep 16, 2025

@jedevc thats the dilemma, right now it doesn't care about the version at all, only whether there is already a dagger binary in the path, and there is no error state. so you have:

preinstalled version requested version result without force-install result with force-install
foo bar foo bar
none bar bar bar
foo foo foo (skipped) foo (downloaded)

my goal was to avoid error states, but we also don't want surprising behavior. The thinking is that if you have dagger pre-installed, you probably expect it to be there. If you want to override that with a specific version, there's a path to do that

Signed-off-by: kpenfound <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Do not install dagger CLI on runner if already present in PATH unless version: specified and different from installed version
3 participants