Skip to content

Avoid fetchAsync when updating/removing a single document by _id #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Avoid fetchAsync when updating/removing a single document by _id #421

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
516f060
Avoid making a database query when updating a single document by _id
alisnic Mar 28, 2025
b7d94c5
Optimize remove
alisnic Mar 28, 2025
c2b3e98
Revert "Optimize remove"
alisnic Mar 28, 2025
0c2c934
Optimize remove
alisnic Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/mongo/Mutator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ export default class Mutator {
...findOptions,
fields: {},
}).fetchAsync();
} else if (Object.keys(selector).length === 1 && typeof selector._id === "string") {
// if we are updating a single document by id, we can skip the find
docs = [{ _id: selector._id }];
} else {
docs = await this.find(selector, findOptions).fetchAsync();
}
Expand Down Expand Up @@ -340,8 +343,14 @@ export default class Mutator {
delete removeOptions.projection;
}

// TODO: optimization check if it has _id or _id with {$in} so we don't have to redo this.
const docs = await this.find(selector, removeOptions).fetchAsync();
let docs

if (!shouldIncludePrevDocument(this) && Object.keys(selector).length === 1 && typeof selector._id === 'string') {
docs = [{ _id: selector._id }];
} else {
docs = await this.find(selector, removeOptions).fetchAsync();
}

let docIds = docs.map((doc) => doc._id);

if (!selector._id) {
Expand Down