-
-
Notifications
You must be signed in to change notification settings - Fork 84
Open
Description
For #365 I've been reading over the reconnect code. If I'm reading https://github.com/cult-of-coders/redis-oplog/blob/master/lib/redis/RedisSubscriptionManager.js correctly:
- attach() may add the same
redisSubscriber
tothis.store[channel]
for multiplechannel
s. - getAllRedisSubscribers() will then get all copies of all
redisSubscriber
s, causing onConnect() to reload some subscribers many times.
Assuming folks agree with me, I'm happy to prepare a PR where getAllRedisSubscribers
deduplicates all the redisSubscriber
s using a Set
. But I just wanted to double-check I'm not missing something first.
(In my application, I'm pretty sure each redisSubscriber
has only one relevant channel, so this doesn't affect me. But it struck me when reading the code.)
Metadata
Metadata
Assignees
Labels
No labels