fix: Redundant Python test workflow run on pre-commit changes #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should run whenever there is a push to a Renovate branch. Doesn't require an additional run on same code if is also on a pull request.
No. For minor and patch upgrades Renovate is allowed by bypass CI if the tests are passing. |
mpkorstanje
requested changes
Sep 15, 2025
| @@ -15,7 +15,6 @@ on: | |||
| branches: | |||
| - main | |||
| paths: | |||
| - .pre-commit-config.yaml | |||
There was a problem hiding this comment.
The on.push trigger is limited to push on the main and renovate/** branches. So by removing this nothing will run when I push to feature/example-feature or when I create a PR targeting main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should run whenever there is a push to a Renovate branch. Doesn't require an additional run on same code if is also on a pull request.
🤔 What's changed?
Remove Python test workflow run on pre-commit pull request changes.
⚡️ What's your motivation?
Avoid redundant duplicate Python test workflow runs on renovate changes to pre-commit configuration (see #336); added within #324.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist: