Skip to content

fix(schema-compiler): propagate FILTER_PARAMS from view to inner cube's SELECT #8466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 5, 2024
Merged

fix(schema-compiler): propagate FILTER_PARAMS from view to inner cube's SELECT #8466

merged 9 commits into from
Sep 5, 2024

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jul 15, 2024 •
edited
Loading

Fix with propagating FILTER_PARAMS from views to inner Cube's SELECT statements.

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:20am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:20am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:20am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:20am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:20am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:20am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:20am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:20am

@KSDaemon KSDaemon force-pushed the fix/filter-params branch from 33cd9f8 to 97713c8 Compare July 15, 2024 19:36
@igorlukanin
Copy link
Member

@KSDaemon Will it close #7062?

@KSDaemon
Copy link
Member Author

KSDaemon commented Jul 16, 2024 •
edited
Loading

@igorlukanin Probably yes... Let me investigate it more before I loud answer :)

@KSDaemon KSDaemon force-pushed the fix/filter-params branch 6 times, most recently from 91bbc26 to c2f51ed Compare July 19, 2024 11:36
@KSDaemon KSDaemon marked this pull request as ready for review July 19, 2024 12:13
@KSDaemon KSDaemon requested review from a team as code owners July 19, 2024 12:13
@KSDaemon KSDaemon force-pushed the fix/filter-params branch 2 times, most recently from 05bd69c to b6ec325 Compare July 19, 2024 17:00
@KSDaemon KSDaemon marked this pull request as draft July 19, 2024 17:25
@KSDaemon KSDaemon marked this pull request as ready for review July 22, 2024 11:40
@KSDaemon KSDaemon force-pushed the fix/filter-params branch from d3fa48e to c5039b9 Compare July 24, 2024 09:20
@KSDaemon KSDaemon merged commit c0466fd into master Sep 5, 2024
@KSDaemon KSDaemon deleted the fix/filter-params branch September 5, 2024 19:17
@KSDaemon KSDaemon restored the fix/filter-params branch September 5, 2024 20:45
@KSDaemon KSDaemon deleted the fix/filter-params branch September 20, 2024 09:16
@Spark-NF Spark-NF mentioned this pull request Sep 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paveltiunov paveltiunov paveltiunov approved these changes

@ovr ovr ovr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KSDaemon @igorlukanin @paveltiunov @ovr