refactor: add test to verify update event handle

[amarlearning]

Add test to verify update event handled by CRI-O

Does this PR introduce a user-facing change?

None

[haircommander]

/release-note-none

[coveralls]

Pull Request Test Coverage Report for Build 5412003644

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 66.387%

---

Totals
Change from base Build 5308798113:	0.0%
Covered Lines:	474
Relevant Lines:	714

---

💛 - Coveralls

[amarlearning]

@haircommander the network config does get updated automatically when we update the config file.

[amarlearning]

@haircommander I have added the test to verify that when the network config file changes, the CRI-O network plugin automatically picks up the new config.

[haircommander]

/approve

so has CRI-O always caught modify events or is it just now doing so? After we merge this, we can maybe add a bats test in CRI-O to check there as well e2e

@cri-o/ocicni-maintainers PTAL

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amarlearning, haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[saschagrunert]

/lgtm

[amarlearning]

@haircommander I looked at the git history to cross-check on this and it seems like the modify event code has been there for some time.

I think it makes sense to now add a bats test in CRI-O to check there as well e2e.

[saschagrunert]

I think it makes sense to now add a bats test in CRI-O to check there as well e2e.

@amarlearning are you going to take care of this? :)

[amarlearning]

inotify wirte events do tell us if a new file has been created or if there is an update in the existing file. Not sure if this was there before, they might have recently added the update events in the write method which eventually resolved the issue.

@saschagrunert I think we should cross-verify this part before we make an effort to write the bats test. Let me know what you think.

[amarlearning]

I went through the release notes of both inotify and fsnotify to find when they added the IN_MODIFY event to the package and it seems they have added it long back. I guess we can write the bats test to catch this issue.

@saschagrunert yes, I will take care of this.