9p: add 9p fuse client #1123
9p: add 9p fuse client #1123
Conversation
Reviewer's GuideThis PR enhances the createdisk.sh script to support 9P file sharing on Windows by adding steps that enable a COPR repository and download the 9pfs binary via SSH when generating the Windows bundle, then include it in the installation list. Flow diagram for 9P FUSE client installation in createdisk.shflowchart TD
A[Start createdisk.sh] --> B{Is SNC_GENERATE_WINDOWS_BUNDLE != 0?}
B -- No --> C[Continue without 9pfs setup]
B -- Yes --> D[Enable COPR repo mskvarla/9pfs via SSH]
D --> E[Create ~/packages directory via SSH]
E --> F[Download 9pfs package to ~/packages via SSH]
F --> G[Add 9pfs to ADDITIONAL_PACKAGES]
G --> H[Continue with install_additional_packages]
C --> H
H[Install additional packages and copy systemd units]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThe script Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
/hold |
redbeam
force-pushed
the
add_9p_fuse_client
branch
2 times, most recently
from
ce67106 to
ab5803b
Compare
This adds a Dockerfile that is used to create a container in which the 9pfs binary is built. The binary is then extracted and installed into the system for 9p file sharing.
redbeam
force-pushed
the
add_9p_fuse_client
branch
from
ab5803b to
a737705
Compare
Removed the container-compilation process and changed it to simple installation from a custom COPR repository that contains the binary.
redbeam
force-pushed
the
add_9p_fuse_client
branch
from
a737705 to
ebb66cd
Compare
|
/unhold |
| fi | ||
|
|
||
| # Beyond this point, packages added to the ADDITIONAL_PACKAGES and PRE_DOWNLOADED_ADDITIONAL_PACKAGES | ||
| # variables won’t be installed in the guest |
There was a problem hiding this comment.
What is our plan around it, always going to use the copr or it is just for initial POC side? As per https://download.copr.fedorainfracloud.org/results/mskvarla/9pfs/srpm-builds/09226159/9pfs.spec file looks like we are just building the binary, can we migrate to container image for this which can be built on brew internally?
There was a problem hiding this comment.
Initially yes, I think the COPR repo should be enough to have this merged, after we see it works, we can move to brew.
9P support for filesharing on Windows: crc-org/crc#4168
Summary by Sourcery
Enhancements:
Summary by CodeRabbit
New Features
Chores