Skip to content

Conversation

vladmsnk
Copy link

@vladmsnk vladmsnk commented Jul 12, 2025

When I try to connect to Oauth provider with wrong url I got wrong error message. In example I use localhost:4444 instead of 127.0.0.1.

Error message:
error="failed to create OAuth service: failed to create OIDC provider: oidc: issuer did not match the issuer returned by provider, expected \"http://localhost:4444\" got \"http://127.0.0.1:4444\""

But should be:
error="failed to create OAuth service: failed to create OIDC provider: oidc: issuer did not match the issuer returned by provider, expected \"http://127.0.0.1:4444\" got \"http://localhost:4444\""

When i change host to http://127.0.0.1:4444, everything works correctly and got no errors

@vladmsnk
Copy link
Author

@ericchiang Hi! could you check this PR please?

@ericchiang
Copy link
Collaborator

Hey! Sorry, but seems like the correct ordering. If the URL you provide to this library is http://localhost:4444, and the server returns something different, then the library expects localhost but got a different value.

Maybe "configured to expect localhost, but server returned 127.0.0.1" would be clearer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants