Revert "build.sh: freeze rpm-ostree on 2025.10-2.fc42" #4329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 712634c. We can have v2025.11 in cosa now that we have new libselinux. We don't strictly need something from it but there's no point in keeping a pin either.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a commit that pinned the rpm-ostree package version. The change is correct as the reason for the pin is no longer valid. I've added one comment suggesting a minor follow-up cleanup to remove the now-unused frozendeps variable for better code maintainability.
for clarity, this is because we tagged https://bodhi.fedoraproject.org/updates/FEDORA-2025-2a0988eb82 into the |
|
CI should be fixed by coreos/fedora-coreos-config#3778. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 712634c.
We can have v2025.11 in cosa now that we have new libselinux.
We don't strictly need something from it but there's no point in keeping a pin either.