Skip to content

Conversation

pdeva
Copy link

@pdeva pdeva commented Jun 17, 2025

currently the check is basically:

minVersion: 0
maxVersion: 0

Scenario:
Assume a Kafka Broker drops support for really old API version of Produce and implements version 3 to 12.

What will happen:
This check will return false and compression will be disabled.

What is expected:
Compression should indeed be supported.

Fix:
The modification fixes the check so that its now:

minVersion: 0
maxVersion: 999

It correctly set the ApiVersion field of struct as min param instead of max

@pdeva pdeva requested a review from a team as a code owner June 17, 2025 18:23
@confluent-cla-assistant
Copy link

confluent-cla-assistant bot commented Jun 17, 2025

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ pdeva
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant