bugfix: correctly set minVersion for compression version check #5118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the check is basically:
Scenario:
Assume a Kafka Broker drops support for really old API version of Produce and implements version 3 to 12.
What will happen:
This check will return false and compression will be disabled.
What is expected:
Compression should indeed be supported.
Fix:
The modification fixes the check so that its now:
It correctly set the
ApiVersion
field of struct asmin
param instead ofmax