Skip to content

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Sep 3, 2025

Video from testing results:

simplescreenrecorder-2025-09-03_12.28.36.mp4

Notes:

Resolutions 4:3 (1440 x 1080) and 3:4 (1080 x 1440) were replaced with 4:3 (1536 x 1152) and 3:4 (1152 x 1536).

These API nodes do not support 4:3 (1440 x 1080) or 3:4 (1080 x 1440), and these resolutions were not defined in parseWidthHeightFromRes, so the 1920 x 1080 resolution was always used instead.

@bigcat88
Copy link
Contributor Author

bigcat88 commented Sep 4, 2025

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Sep 4, 2025
Copy link
Collaborator

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can confirm the change to resolution options is correct.

@comfyanonymous comfyanonymous merged commit 581bae2 into comfyanonymous:master Sep 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Core team dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants