Replace legacy serializer with files handler #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next PR will be on using files handler in describe topic partition and fetch stages respectively. |
rohitpaulk
approved these changes
Sep 12, 2025
| @@ -0,0 +1,171 @@ | |||
| package kafka_files_handler | |||
There was a problem hiding this comment.
Suggested change
| package kafka_files_handler | |
| package kafka_file_generator |
(Handler is pretty generic - since all of this is related to generating files, maybe that's a better name?)
|
Just wanted to say - pretty cleanly done! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could not separate this into smaller PRs. Everything seemed related.