asimview: add sha comparison functionality #153437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds asimview, a Go tool that serves an interactive web viewer for ASIM test JSON output files, replacing the previous static HTML approach with significant improvements. Key features: - Auto-discovery of test files with fuzzy search and multi-select - Instant file loading with persistent file selections across sessions - Metric filtering with persistent preferences (localStorage) - Default metrics: cpu, qps, write_bytes_per_second, replicas, leases - Synchronized zoom across all charts with reliable undo functionality - Copy timeseries data as JSON - Performance optimizations for (relatively) snappy rendering Usage: - go run pkg/kv/kvserver/asim/tests/cmd/asimview - open browser at http://localhost:8080 The tool automatically finds the repo root and serves files from testdata/generated/. The old static viewer.html has been replaced with a README pointing to the new tool. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Cost: $48.59 Epic: CRDB-49117
Added comprehensive SHA comparison capability to the ASIM viewer tool, enabling side-by-side comparison of test results between different Git commits. Major additions: - New `-sha-compare` flag to enable SHA comparison mode - `sha_compare.go`: Core logic for managing Git operations, test generation, and file comparison - `sha_compare.html`: Interactive web interface for SHA comparison with Plotly charts - File-by-file comparison with visual indicators for identical, different, or SHA-specific files The tool now supports two modes: 1. Regular file viewer (existing functionality) 2. SHA comparison mode (new) - allows users to select two commits, automatically generates test data for both, and provides side-by-side chart comparison Updated BUILD.bazel and .gitignore to support the new comparison workflow and temporary file storage. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
wenyihu6
changed the title
|
The discussion this morning was really helpful. I ended up copying the generated data to a temp folder under .gitignore with the sha as the folder name so that it won’t be affected when switching SHAs. Then it switches to another SHA, does the same, and compares the results under the temp directory. It felt somewhat similar to benchdiff. The folder might just keep growing, so I’m relying on users to delete it once they’re done with the tool. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on top of #152959.
Epic: https://cockroachlabs.atlassian.net/browse/CRDB-49117
Release note: none
Added comprehensive SHA comparison capability to the ASIM viewer tool, enabling
side-by-side comparison of test results between different Git commits.
Major additions:
-sha-compareflag to enable SHA comparison modesha_compare.go: Core logic for managing Git operations, test generation, and file comparisonsha_compare.html: Interactive web interface for SHA comparison with Plotly chartsThe tool now supports two modes:
generates test data for both, and provides side-by-side chart comparison
Updated BUILD.bazel and .gitignore to support the new comparison workflow and temporary file storage.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]